Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does this formula assume docker is installed? #4

Closed
BadgerOps opened this issue Oct 23, 2017 · 4 comments
Closed

does this formula assume docker is installed? #4

BadgerOps opened this issue Oct 23, 2017 · 4 comments

Comments

@BadgerOps
Copy link
Contributor

Hello,

Thanks for the prometheus formula! I've been trying to use it in a vagrant environment in preparation for rolling it out to our production environment. I had a bit of an issue getting it to apply initially until I started looking at the SLS files.

I noticed here that in order to apply the server role a 'docker' reference must be defined in pillar. Does this mean this formula is designed specifically for a docker environment, and if so should the documentation be updated to reflect this?

I'd be happy to do so, but it would be nice to have docker be optional instead of assumed. (Again, I'm absolutely willing to write the code to do so)

Thanks!

@asyncmind0
Copy link

asyncmind0 commented Nov 20, 2017

not sure why this is the official salt-formula for prometheus under salt-formulas

https://github.com/richerve/prometheus-formula is much cleaner and does not require docker and k8

also prometheus official doco points to another formula which is again written in a non-standard weird way.

@BadgerOps
Copy link
Contributor Author

Thanks for the link @jagguli - I'll check that formula out.

@fpytloun
Copy link
Member

Hello,

this formula was initially designed to be used with Docker (salt-formula-docker). There's PR #2 to implement local docker-less setup.
Also note that salt-formulas doesn't belong under Saltstack or being anything like Saltstack official.

Anyway any contribution (including documentation, etc.) is appreciated.

@BadgerOps
Copy link
Contributor Author

Thanks for the update @fpytloun !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants