fix(ssr): fix adjacent text node concatenation within slotted content #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last thing to fix is (as always) light DOM slotted content. It has its own pseudo- |
wjhsf
reviewed
Dec 20, 2024
| child.type === 'Text' || (child.type === 'Comment' && !cxt.templateOptions.preserveComments); | ||
|
|
||
| const bMassageTextContent = esTemplate` | ||
| massageTextContent(${/* string value */ is.expression}); |
There was a problem hiding this comment.
I thought we renamed this to normalizeTextContent. I guess not. 🤔
…acent-text-nodes-party-again-yay
|
Closing in favor of #5079 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #5067
Moves adjacent text node concatenation from a runtime concern to a compile-time (AST) concern, which more closely aligns with how
template-compileris doing it.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?