Replies: 1 comment
-
Hey @weisk , |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Yeah , so I was almost ready to hire you, but then I was reading the snippet that programatically describes your coder properties.
I saw your
hireable
function, but then i thought.... why is this even a function if the boolean expression uses its own hardcoded values only, so why not just put the boolean expression outside and execute it only once, so hireable will not bea function but a boolean. Even more, why bother with logical operations when you know it's going to betrue
always, just hardcode true aswell.Ok now joking aside.... hehehe
It's looks cool. Here's a suggestion:
Make your
hireable
function , a function that accepts inputs. Example:and inside, you do some stuff with that.
Like what if my offer says:
{salary: 1M dollars/year}
, and my requirements contain:{daysPerWeek: 6, minWeekHours: 60, yearlyVacationDays: 1}
think about that ;)
Beta Was this translation helpful? Give feedback.
All reactions