Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show / Hide timeline on map filter #23

Open
dhornbein opened this issue Sep 21, 2017 · 7 comments
Open

Show / Hide timeline on map filter #23

dhornbein opened this issue Sep 21, 2017 · 7 comments

Comments

@dhornbein
Copy link

@flavour How can we show/hide the timeline filter elements?

The ideal outcome would be a button that would show/hide the date-filter-chart, range-picker, and the start/end time fields.

Can we wrap these in a block with a class name? Otherwise I think we could target them with jQuery and put them into a block. What are your thoughts?

@flavour
Copy link
Member

flavour commented Sep 21, 2017

It should be easy for me to wrap in a DIV...will you then add the button? or at least the design?

@flavour
Copy link
Member

flavour commented Sep 22, 2017

Wrapper done...was indeed super-easy: sahana/eden@75be978

@dhornbein
Copy link
Author

Should I add the button to modules/s3/s3filter.py or via jQuery? What's the best practice?

@flavour
Copy link
Member

flavour commented Sep 26, 2017

This widget is doing it all in s3.filter.js currently

@dhornbein
Copy link
Author

I completed it via jQuery. It's a bit hacky, if you have a better way to trigger this please do.

There seems to be some issues with drawing the timeline, do you have a solution for redrawing the timeline on toggle?

screen shot 2017-09-27 at 2 49 08 pm

I appears to draw the timeline while it's shrinking...

@dhornbein
Copy link
Author

@flavour should I make a PR with this working but buggy implementation? I think we just need to redraw the timeline after revealing the timeline.

@flavour
Copy link
Member

flavour commented Jan 22, 2018

Sure, make a PR, then it can be reviewed there...perhaps I'll take elements from it & place it into a full solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants