Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fetch txDetails for Batch Execute #2487

Closed
usame-algan opened this issue Sep 4, 2023 · 3 comments
Closed

Don't fetch txDetails for Batch Execute #2487

usame-algan opened this issue Sep 4, 2023 · 3 comments

Comments

@usame-algan
Copy link
Member

This issue is currently blocked by #2011

What is the feature about

We fetch txDetails for every transaction that is part of the batch when using Batch Execute in the UI. This is because we need the dataDecoded in order to display what each transaction does (method name, parameters). Once Human-readable transactions are implemented we will have access to that information without having to fetch txDetails.

The list of requirements

  • Remove txDetails requests from Batch Execute
  • Use txInfo.humanDescription or txInfo.richInfo instead
@usame-algan
Copy link
Member Author

This would also address 5afe/safe-support#269

Discussion on Slack

@iamacook
Copy link
Member

It looks like we will need to fetch them for execution as we extract the arguments of a transaction from the txDetails.

@usame-algan
Copy link
Member Author

It looks like we will need to fetch them for execution as we extract the arguments of a transaction from the txDetails.

True, that means we can't get rid of the fetch calls and need to tackle this on the CGW. I will close this issue and bring it up on Slack.

@github-project-automation github-project-automation bot moved this from New issues to Done in Web Squad Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants