Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom safe apps don't load unless they contain a trailing slash #4347

Open
usame-algan opened this issue Oct 9, 2024 · 0 comments · May be fixed by #4348
Open

Custom safe apps don't load unless they contain a trailing slash #4347

usame-algan opened this issue Oct 9, 2024 · 0 comments · May be fixed by #4348
Assignees
@usame-algan
Labels
bug Something isn't working

Comments

@usame-algan
Copy link
Member

Bug description

When adding a custom safe app, the trailing slash is removed. Without a trailing slash the safe app doesn't open unless it is added back manually in the URL

Related issue: #732

Steps to reproduce

  1. Go to safe apps
  2. Add a custom safe app
  3. Copy a safe app url with a trailing slash
  4. Try to open that safe app afterwards

Expected result

The safe app opens

Obtained result

The safe app is loading indefinitely
@usame-algan usame-algan added the bug Something isn't working label Oct 9, 2024
@usame-algan usame-algan self-assigned this Oct 9, 2024
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Oct 9, 2024
@usame-algan usame-algan moved this from New issues to Peer Review in Safe{Wallet} Oct 9, 2024
@usame-algan usame-algan linked a pull request Oct 9, 2024 that will close this issue
Draft
3 tasks
@liliya-soroka liliya-soroka moved this from Peer Review to Ready for QA in Safe{Wallet} Oct 15, 2024
@katspaugh katspaugh moved this from Ready to merge to Todo in Safe{Wallet} Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usame-algan usame-algan

Labels
bug Something isn't working
Projects
Safe{Wallet}
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Don't trim trailing slashes from safe apps safe-global/safe-wallet-monorepo
1 participant
@usame-algan