Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The protocol-kit instance should refresh after a deployment has been made through the 4337pack #1024

Open
louis-md opened this issue Oct 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@louis-md
Copy link

louis-md commented Oct 25, 2024

Description

When using the safe4337Pack, deploying a Safe does not update the protocol kit accessible at safe4337Pack.protocolKit (even if safe4337Pack.protocolKit.isSafeDeployed will correctly return true). Subsequent actions using the protocol-kit will return the error:

/node_modules/@safe-global/protocol-kit/dist/src/managers/ownerManager.js:115 throw new Error('Safe is not deployed');).

Steps to reproduce

Steps can be found in this Stack Exchange question.

Expected result

safe4337Pack.protocolKit should be refreshed after deployment, so further actions can be made without having to use safe4337Pack.protocolKit.connect(...).

@dasanra dasanra added the bug Something isn't working label Oct 25, 2024
@salochara
Copy link

Hi!!

Just wanted to ask if there's an estimated timeframe for tackling this?
This would be very helpful for planning purposes on my end.

All the best and thanks for your awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants
@louis-md @salochara @dasanra and others