You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the implementation of "native WalletConnect", the details of the connected DApp (name, icon, etc.) are available and could be sent as part of the transaction origin. We currently map this to Safe Apps.
The client currently sends the WalletConnect Safe App as the origin to show the icon in the transaction list:
The client could alternatively send the DApp details and we could return the origin "as is" if no Safe App is found. This would allow the client to display DApp icons in the transaction list instead.
Considerations
Should we instead add a different key, e.g. dappInfo, as this is technically not from a Safe App
Does this have any security implications?
The text was updated successfully, but these errors were encountered:
The scope of this feature was relatively big because the interface would take into consideration external projects or reaching a format that would be both extensible and robust (community driven).
However the scope can be reduced if this is tackled mostly by the Safe Client Gateway. That is, the scope would not change on the Safe{Core} side and therefore the Safe Transaction Service but start as a proposal to be tackled on the Safe{Wallet} side before pushing this to be more of an "open" format.
Feature request
With the implementation of "native WalletConnect", the details of the connected DApp (name, icon, etc.) are available and could be sent as part of the transaction
origin
. We currently map this to Safe Apps.The client currently sends the WalletConnect Safe App as the
origin
to show the icon in the transaction list:The client could alternatively send the DApp details and we could return the
origin
"as is" if no Safe App is found. This would allow the client to display DApp icons in the transaction list instead.Considerations
dappInfo
, as this is technically not from a Safe AppThe text was updated successfully, but these errors were encountered: