Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #1924

Open
PooyaRaki opened this issue Sep 13, 2024 · 0 comments
Open

Improve error handling #1924

PooyaRaki opened this issue Sep 13, 2024 · 0 comments

Comments

@PooyaRaki
Copy link
Contributor

PooyaRaki commented Sep 13, 2024

Our current error handling implementation has room for improvement in providing clear and consistent error messages to the client. Enhancing this aspect will help in troubleshooting issues more effectively and improve overall user experience.

Objectives:
Review and Refactor Error Handling Logic: Assess the existing error handling mechanisms to identify areas where error processing and communication can be improved.
Testing and Validation: Add comprehensive tests to validate the new error handling behavior and confirm that the improvements address the current shortcomings.

Acceptance Criteria:

  • All error responses follow the standardized format.
  • The refactoring does not introduce breaking changes for existing clients.
  • Error messages are clear, actionable, and provide sufficient information for debugging.
    • Validation errors should return 4XX for client submitted data.
  • Tests cover a variety of error scenarios and confirm correct behavior.

Example
If an env. var. is not set, calling getOrThrow on the configuration service will thrown an unknown error that is otherwise hard to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant