Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect scorer model type #30

Open
ljleb opened this issue Mar 23, 2023 · 2 comments
Open

Detect scorer model type #30

ljleb opened this issue Mar 23, 2023 · 2 comments
Labels
feature New feature or request question Further information is requested scorer

Comments

@ljleb
Copy link
Contributor

ljleb commented Mar 23, 2023

Is there any way of detecting the type of scorer model used? Instead of having to tell the script which type of model it is, we could test for the presence or absence of some properties maybe. This would make the gradio interface easier to use.

@ljleb
Copy link
Contributor Author

ljleb commented Mar 24, 2023

Ah wait. In the main script, we have these lines:

if kwargs["scorer_method"] == "laion":
kwargs["scorer_model_name"] = "laion-sac-logos-ava-v2.safetensors"
elif kwargs["scorer_method"] == "aes":
kwargs["scorer_model_name"] = "aes-B32-v0.safetensors"
elif kwargs["scorer_method"].startswith("cafe"):
kwargs["scorer_model_name"] = ""

I take this means we are not supposed to pass --scorer_method to cli args when passing --scorer_model_name?

@s1dlx
Copy link
Owner

s1dlx commented Mar 24, 2023

close...that means that when you pass --scorer_method laion (or aes or any of the cafe_*), there's no need for a --scorer_model_name as it is filled in for you

I'm thinking of splitting chad into three sub-methods (like cafe_*) so that we can remove --scorer_model_name alltogether

@s1dlx s1dlx added question Further information is requested feature New feature or request labels Mar 24, 2023
@s1dlx s1dlx added the scorer label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request question Further information is requested scorer
Projects
None yet
Development

No branches or pull requests

2 participants