Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dracula theme not rendering the same colors across clients #8

Closed
JJGadgets opened this issue Mar 20, 2021 · 7 comments
Closed

Dracula theme not rendering the same colors across clients #8

JJGadgets opened this issue Mar 20, 2021 · 7 comments

Comments

@JJGadgets
Copy link

I have opened an issue on the Dracula Standard Notes repo, but figured I should link it here too, since it affects the Org Mode editor the most (Markdown Pro didn't have the same issue as far as I can tell)
dracula/standard-notes#7

@ryanpcmcquen
Copy link
Owner

The editor has no way to know the theme. I created upstream issues about this already, but that is why the Org mode editor has a light/dark switch, so it at least can be usable.

@ryanpcmcquen
Copy link
Owner

The Org mode editor is different from most editors in that it changes the color of certain things as well.

@ryanpcmcquen
Copy link
Owner

Related upstream issue:
standardnotes/component-relay#13

@JJGadgets
Copy link
Author

why the Org mode editor has a light/dark switch, so it at least can be usable.

Unfortunately, except for Dark Mode on my PopOS install, both modes seem to be incorrect.

Also (I'll open a new issue if needed) the Light/Dark switch's background bar seems to not change colors depending on light/dark. I'd appreciate if it was either adaptive, or just blends into the rest of the chosen Standard Notes theme.

it changes the color of certain things as well.

Such as? Fast Editor as far as I can tell doesn't do this, for example.

@ryanpcmcquen
Copy link
Owner

Italics and code text are a different color than standard text for example.

@ryanpcmcquen
Copy link
Owner

The switcher bar isn't intended to change. As noted earlier, Standard Notes doesn't expose colors to the editor, so making it 'adaptive' is not possible with Standard Notes as it is today.

@ryanpcmcquen
Copy link
Owner

Nothing to fix until Standard Notes exposes this data, which they don't seem interested in doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants