Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fira Code's progress bars and spinner. #1345

Closed
oshaboy opened this issue Sep 3, 2023 · 7 comments · May be fixed by #1733
Closed

Add Fira Code's progress bars and spinner. #1345

oshaboy opened this issue Sep 3, 2023 · 7 comments · May be fixed by #1733
Labels
❲+❳ add glyph to core set keep_unlocked Allow discuissions for extended time even after closing

Comments

@oshaboy
Copy link

oshaboy commented Sep 3, 2023

Requirements

  • [*] I have searched the issues for my request and found nothing related and/or helpful
  • [*] I have searched the FAQ for help
  • [*] I have searched the Wiki for help

Is your feature request related to a problem? Please describe.
It's not a problem it's a request for more symbols from Fira Code.

Describe the solution you'd like
I would like the Fira Code progress bar and spinner to be added to the font.

Describe alternatives you've considered
The only fonts I know that support Fira Code's progress bar and spinner are Fira Code and Iosevka.

Additional context

Fira Code added glyphs for a progress bar and spinner in the PUA. Not much software support for them is out there. It feels like they should be glyphs in nerd fonts but they aren't.
@oshaboy
Copy link
Author

oshaboy commented Nov 27, 2023

Shouldn't this be added to #1095. I didn't know about that thread when I made this issue

@Finii
Copy link
Collaborator

Finii commented Nov 28, 2023

It should, and it will ;-D
And it is correct (best) to create this issue here. Direct adding to 1095 is not good.

At the moment I still work on the 3.1.x release which absorbs about 120% of the time I can allot for Nerd Fonts.
Please bear with me.

@mikesmithgh
Copy link

mikesmithgh commented Nov 29, 2023 •
edited
Loading

Hey 👋, this is really nice. I am using Fira Code Nerd Font v3.1.0 and can see the spinners.

I modified test-fonts.sh locally for experimenting.

	echo "Nerd Fonts - Fira"
	print-unicode-ranges ee00 ee0b ee10 ee15
	echo
	echo

fira-nerd-fonts

I have a question around what this ticket actually means for implementation.

  1. Since I can see the symbols, does this mean that this is already implemented in v3.1.0 ?
    or
  2. Will this add these symbols be patched to all Nerd Fonts and maybe use another private-use unicode area?

@mikesmithgh mikesmithgh mentioned this issue Nov 29, 2023
Merged
1 task
@Finii
Copy link
Collaborator

Finii commented Nov 29, 2023 •
edited
Loading

Type fc-list :charst=ee00 and see where the icons come from. Nerd Font does not patch in anything at EE00, see https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points#overview

The spinners are originally in Fira (so if you use Fira or a patched version of it they are there).
This Issue aims to steam steal them from Fira and put them in all fonts.

@oshaboy
Copy link
Author

oshaboy commented Nov 29, 2023

Yeah a lot of terminals if you don't have characters in the default font it tries fallback fonts.

@mikesmithgh
Copy link

Type fc-list :charst=ee00 and see where the icons come from. Nerd Font does not patch in anything at EE00, see https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points#overview

The spinners are originally in Fira (so if you use Fira or a patched version of it they are there). This Issue aims to steam steal them from Fira and put them in all fonts.

Thanks!

fc-list ':charset=ee00' | grep Fira
/Users/mike/Library/Fonts/FiraCodeNerdFont-Regular.ttf: FiraCode Nerd Font:style=Regular

That makes sense, I am using Kitty and explicitly setting the symbol_map to FiraCode Nerd Font

I got excited when I saw these and didn't realize they were Fira exclusive. I look forward to you steaming stealing them 🙂

@mikesmithgh mikesmithgh mentioned this issue Dec 13, 2023
Closed
@Finii
Copy link
Collaborator

Finii commented Mar 24, 2024

Closing because transferred to #1095

@Finii Finii closed this as completed Mar 24, 2024
@Finii Finii mentioned this issue Apr 7, 2024
Closed
3 tasks
@Finii Finii added the keep_unlocked Allow discuissions for extended time even after closing label Apr 18, 2024
@Finii Finii mentioned this issue Apr 22, 2024
Open
Finii added a commit that referenced this issue Nov 14, 2024
@Finii
font-patcher: Add progress indicators
d89c9a4 
Fixes: #1345

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii mentioned this issue Nov 14, 2024
Draft
4 tasks
Finii added a commit that referenced this issue Nov 14, 2024
@Finii
font-patcher: Add progress indicators
bd59368 
[note]
Glyphs taken from FiraCode; remove negative bearings and add a helper
glyphs for vertical alignment that is used for the combined boundingbox
calculation but not patched in.

Fixes: #1345

Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
❲+❳ add glyph to core set keep_unlocked Allow discuissions for extended time even after closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

font-patcher: Add progress indicators ryanoasis/nerd-fonts
3 participants
@mikesmithgh @Finii @oshaboy