Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto playing state recovery option to play() #555

Open
addie9000 opened this issue Oct 15, 2021 · 0 comments
Open

Add auto playing state recovery option to play() #555

addie9000 opened this issue Oct 15, 2021 · 0 comments
Assignees
Labels
1 backlog enhancement New feature or request

Comments

@addie9000
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If play fails some reason, the playing state remains as true even though not playing.
This is exactly what the state diagram said. However if play occurs audio session error, the playing state goes back to false, because audio session error can handle synchronously.

Describe the solution you'd like
Add option something like bool auto_state_recovery to play method and if it's true, set playing state as false if play fails not only synchronous but also asynchronous.

Describe alternatives you've considered
Because we can handle this as long as play reports error properly, just leave this as is. If so, it's very nice if there is a bit clear document about playing state with error.

Additional context
Originally came up from #554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants