-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error generating rxn_maps due to mismatch in array size #56
Comments
Hi, My best guess is that the reaction SMILES strings are too long for the current model, but happy to check directly. |
Hi. Thank you so much for helping me out with this issue. Here are some SMILES examples for the errors I've mentioned above: Error 1: index X is out of bounds for axis 0 with size X
Error 2: could not broadcast input array from shape (A,) into shape (B,)
Error 3: The size of tensor a (D) must match the size of tensor b (512) at non-singleton dimension 1
|
Thanks for the examples! I started looking into it and will shortly have a fix for Errors 1 and 2. This was caused by the presence of asterisks in the reaction SMILES, which sometimes stand for atom placeholders. After the fix, these reactions should succeed. Error 3 seems to be caused by too long reaction SMILES. I'll improve the error message for these. |
Errors 1 and 2 fixed by #57. |
Error message for 3 improved in #58. |
The new version on PyPi (0.4.0) should cover all the above! Feel free to reopen this issue if needed. |
Hello,
I am trying to generate atom mappings for some 30,000 reaction SMILES. These reaction SMILES are generated for the reactions from the Rhea database. I download the mol files of the participating metabolites for ChEBI, generate SMILES using RDKIT and then concatenate them using
.
and>>
to generate reaction SMILES.Using,
BatchedMapper
I am able to successfully generate atom maps for 24,600 of them. For the remaining 5000ish, when I useRxnMapper
to identify the cause of error I get a few different error types:Error 2 accounts for the vast majority of unsuccessful maps.
I am from a data science background and have zero chemistry knowledge and thus, while I understand the error messages, I do not understand what is causing them.
It would be really great if the authors of
rxnMapper
could help me out here. Please let me know if you need more details regarding the errors I am getting.The text was updated successfully, but these errors were encountered: