Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove code duplication: recognition and sat_recognition #38

Open
christophmluscher opened this issue Feb 7, 2022 · 0 comments
Open
Assignees

Comments

@christophmluscher
Copy link
Contributor

For GmmSystem in common/setups/rasr/gmm_system.py:

Can we maybe expand this step to incorporate also sat_recognition?

E.g. have a flag in the step_args and then do smth like

recog_funktion = self.sat_recognition if step_args["sat"] else self.recognition
This way we could simplify / deduplify some code above in the run_sat_step

Originally posted by @michelwi in #33 (comment)

@christophmluscher christophmluscher self-assigned this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant