Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pskN modifier supports #28

Open
cute opened this issue Oct 18, 2017 · 4 comments
Open

pskN modifier supports #28

cute opened this issue Oct 18, 2017 · 4 comments

Comments

@cute
Copy link

cute commented Oct 18, 2017

protocol Noise_IKpsk2_25519_ChaChaPoly_BLAKE2s is invalid name.

@nazar-pc
Copy link
Contributor

noise-c doesn't implement the latest version of the spec yet.
Hopefully, soon...

@rweather
Copy link
Owner

rweather commented Nov 1, 2017

I apologise for how long this is taking. My day job has been eating all my time over the last few months, leaving little time for noise-c.

I have pushed my in-progress rev32 work to the repository under the "rev32" branch. I was in the middle of trying to get the cacophony test vectors for PSK's to work with noise-c. There was also still some work to do on converting the way fallback works.

Any assistance to finish this off would be greatly appreciated.

@pallas
Copy link
Contributor

pallas commented Apr 17, 2019

FYI, I have a fix I'm working on for the above. The vectors pass now, I just need to clean some things up.

@pallas
Copy link
Contributor

pallas commented Apr 17, 2019

tl;dr is the following issue in the spec: when there are any PSKs, the E state goes from just calling MixHash to calling MixHash, then MixKey.

This was referenced Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants