Use portable-atomic when AtomicU64 is not available. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Flávio J. Saraiva <[email protected]>
Signed-off-by: Flávio J. Saraiva <[email protected]>
flaviojs
requested review from
liujing2,
sameo,
andreeaflorescu,
jiangliu,
roypat and
ShadowCurse
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Use portable-atomic when AtomicU64 is not available.
Fixes #187
I do not know if AtomicU64 is required, or why other atomic types don't implement Metric.
If it is not required, an alternate change is to use the more portable AtomicUsize.
It is unclear if the changes to test
linux::sock_ctrl_msg::tests::buffer_lenare appropriate since I don't use this crate.All tests pass in my 32-bit OS except the doc-tests
linux::ioctl::ioctlandlinux::ioctl::ioctl_with_val.These failures are expected because I don't have
/dev/kvm.I do not know what should go into the changelog so I left it unchanged.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.