Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrete Gaussian distribution in rand_distr? #1404

Open
ooovi opened this issue Mar 6, 2024 · 1 comment
Open

Discrete Gaussian distribution in rand_distr? #1404

ooovi opened this issue Mar 6, 2024 · 1 comment

Comments

@ooovi
Copy link

ooovi commented Mar 6, 2024

I implemented a sampler for the Discrete Gaussian distribution for another project. The distribution is a discretization of the normal distribution that converges in a desirable way and allows to circumvent certain serious issues that can arise when attempting to provide differential privacy.

The implementation has been reviewed and tested against the python reference implementation, and I wrote some empirical tests as well. It is currently part of the libprio-rs crate and hence not easily reusable.

Is this the kind of distribution you think would make sense to include in rand_distr, or should i go for a seperate crate? I'm willing to make a pull request, if you're interested.

@dhardy
Copy link
Member

dhardy commented Mar 18, 2024

I don't know how widely applicable this distribution is, and don't have the time to read into it.

At a glance, your code looks well structured, documented and tested, so I'm tempted to say yes please, at some risk of rand_distr continuing to grow as an uncoordinated and poorly maintained aggregation of stochastic samplers.

@vks do you have any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants