From 6e948929eaae2dea923717f3a6ef9f1a2cbb0bf6 Mon Sep 17 00:00:00 2001
From: Keith Bennett <keithrbennett@gmail.com>
Date: Tue, 30 Jul 2019 12:21:53 -0400
Subject: [PATCH] #156 Added "Not Provided" for fields with missing
 information. (#158)

* #156 Added "Not Provided" for fields with missing information.

* Use instance variable so that 'Not Provided' is defined only once, to prevent misspelling and simplify modification.

* Use Rails internationalization for string "Not Provided".

* Removed @not_provided variable assignment no longer needed.
---
 app/views/partners/show.html.erb | 26 +++++++++++++-------------
 config/locales/en.yml            |  1 +
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/app/views/partners/show.html.erb b/app/views/partners/show.html.erb
index e7d4548e..89e547a2 100644
--- a/app/views/partners/show.html.erb
+++ b/app/views/partners/show.html.erb
@@ -207,48 +207,48 @@
 
                   <h6>Ethnic Composition of Those Served</h6>
                   <dt>African American</dt>
-                  <dd><%= @partner.population_black %></dd>
+                  <dd><%= @partner.population_black || t(:not_provided) %></dd>
 
                   <dt>Caucasian</dt>
-                  <dd><%= @partner.population_white %></dd>
+                  <dd><%= @partner.population_white || t(:not_provided) %></dd>
 
                   <dt>Hispanic</dt>
-                  <dd><%= @partner.population_hispanic %></dd>
+                  <dd><%= @partner.population_hispanic || t(:not_provided) %></dd>
 
                   <dt>Asian</dt>
-                  <dd><%= @partner.population_asian %></dd>
+                  <dd><%= @partner.population_asian || t(:not_provided) %></dd>
 
                   <dt>American Indian</dt>
-                  <dd><%= @partner.population_american_indian %></dd>
+                  <dd><%= @partner.population_american_indian || t(:not_provided) %></dd>
 
                   <dt>Pacific Islander</dt>
-                  <dd><%= @partner.population_island %></dd>
+                  <dd><%= @partner.population_island || t(:not_provided) %></dd>
 
                   <dt>Multi-racial</dt>
-                  <dd><%= @partner.population_multi_racial %></dd>
+                  <dd><%= @partner.population_multi_racial || t(:not_provided) %></dd>
 
                   <dt>Other</dt>
-                  <dd><%= @partner.population_other %></dd>
+                  <dd><%= @partner.population_other || t(:not_provided) %></dd>
 
                   <dt>Zip Codes Served</dt>
                   <dd><%= @partner.zips_served %></dd>
 
                   <h6>Poverty Information of Those Served</h6>
                   <dt>At FPL or below</dt>
-                  <dd><%= @partner.at_fpl_or_below %></dd>
+                  <dd><%= @partner.at_fpl_or_below || t(:not_provided) %></dd>
 
                   <dt>Above 1-2 times FPL</dt>
-                  <dd><%= @partner.above_1_2_times_fpl %></dd>
+                  <dd><%= @partner.above_1_2_times_fpl || t(:not_provided) %></dd>
 
                   <dt>Greater than 2 times FPL</dt>
-                  <dd><%= @partner.greater_2_times_fpl %></dd>
+                  <dd><%= @partner.greater_2_times_fpl || t(:not_provided) %></dd>
 
                   <dt>Poverty Unknown</dt>
-                  <dd><%= @partner.poverty_unknown %></dd>
+                  <dd><%= @partner.poverty_unknown || t(:not_provided) %></dd>
 
                   <h6>Ages Served</h6>
                   <dt>Ages</dt>
-                  <dd><%= @partner.ages_served %></dd>
+                  <dd><%= @partner.ages_served || t(:not_provided) %></dd>
                 </dl>
               </div>
             </div>
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 2c5c77fa..c0e46007 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -30,6 +30,7 @@
 # available at http://guides.rubyonrails.org/i18n.html.
 
 en:
+  not_provided: "Not Provided"
   hello: "Hello world"
   :true: 'Yes'
   :false: 'No'