☂️ fix or remove xit-ignored tests

[elasticspoon]

We have a page /volunteers that uses datatables. This means that sometimes parts of the page don't always load in time when running system tests. Because we had so many issues with flakiness we ended up removing the tests.

All the issues below have a similar theme. For each one figure out how to unflake the test, or if the test does not have much purpose remove it. I imagine there should be some way to ensure the test waits long enough for the data tables to get their job done.

This is a epic issue meant to consolidate the following issues that all deal with similar problems:

• Fix or remove xit-ignored test in spec/requests/case_assignments_spec.rb:353 'does not toggle contacts visibility' #5669
• Fix or remove xit-ignored test in spec/requests/case_assignments_spec.rb:353 'renders the edit page?' #5670
• Fix or remove xit-ignored test in spec/system/case_court_reports/index_spec.rb:199 'selects the correct case, js: true do # TODO make this work' #5671
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'does not display by default' #5672
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'is displayed' #5673
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'displays number of volunteers selected' #5674
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'text matches pluralization of volunteers selected' #5675
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'is hidden when all volunteers unchecked' #5676
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'selects all volunteers' #5677
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'deselects all volunteers' #5678
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'is semi-checked (indeterminate)' #5679
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'selects all volunteers' #5680
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'is disabled by default' #5681
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'is enabled do # TODO: Flaky. Fix this test' #5682
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'is enabled' #5683
• Fix or remove xit-ignored test in spec/system/volunteers/index_spec.rb:486 'is disabled' #5684
• Fix or remove xit-ignored test in spec/views/notifications/index.html.erb_spec.rb:88 'has all notifications created after and including the deploy date above the patch note' #5685
• Fix or remove xit-ignored test in spec/views/notifications/index.html.erb_spec.rb:88 'has all notifications created after and including the deploy date above the patch note' #5686
• Fix or remove xit-ignored test in spec/views/notifications/index.html.erb_spec.rb:88 'shows the correct number of notifications' #5687

[github-actions]

This issue has been inactive for 249 hours (10.38 days) and will be unassigned after 111 more hours (4.63 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

[github-actions]

This issue has been inactive for 369 hours (15.38 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

[github-actions]

This issue has been open without changes for a long time! What's up?