Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include type and stackTrace in logging for console API #419

Open
alexeyr-ci opened this issue Nov 21, 2023 · 0 comments
Open

Include type and stackTrace in logging for console API #419

alexeyr-ci opened this issue Nov 21, 2023 · 0 comments

Comments

@alexeyr-ci
Copy link

We have

ferrum/lib/ferrum/page.rb

Lines 358 to 362 in 98a7acb

if @browser.options.logger
on("Runtime.consoleAPICalled") do |params|
params["args"].each { |r| @browser.options.logger.puts(r["value"]) }
end
end

but it doesn't include params["type"] or params["stackTrace"], and they seem to be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant