activesupport: Add types for to_fs #754
Conversation
dak2
commented
Dec 18, 2024
dak2
commented
- ActiveSupport::NumericWithFormat
- https://api.rubyonrails.org/v7.0.8.6/classes/ActiveSupport/NumericWithFormat.html#method-i-to_fs
- ActiveSupport::RangeWithFormat
- https://api.rubyonrails.org/v7.0.8.6/classes/ActiveSupport/RangeWithFormat.html#method-i-to_fs
- Array
- https://api.rubyonrails.org/v7.0.8.6/classes/Array.html#method-i-to_fs
- Date
- https://api.rubyonrails.org/v7.0.8.6/classes/Date.html#method-i-to_fs
- DateTime
- https://api.rubyonrails.org/v7.0.8.6/classes/DateTime.html#method-i-to_fs
- Time
- https://api.rubyonrails.org/v7.0.8.6/classes/Time.html#method-i-to_fs
|
@dak2 Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
| # 1234567.to_fs(:human, precision: 1, | ||
| # separator: ',', | ||
| # significant: false) # => "1,2 Million" | ||
| def to_fs: (?Symbol format, *untyped) -> String |
There was a problem hiding this comment.
The second argument is a Hash object or kwargs.
https://github.com/rails/rails/blob/v7.0.8.7/activesupport/lib/active_support/core_ext/numeric/conversions.rb#L111
How about this?
| def to_fs: (?Symbol format, *untyped) -> String | |
| def to_fs: (?Symbol format, **untyped) -> String |
| def to_fs: (?Symbol format, *untyped) -> String | |
| def to_fs: (?Symbol format, Hash[untyped, untyped]?) -> String |
either is okay to me.
There was a problem hiding this comment.
I chose **untyped that simply statement. Thanks for pointing that out!
| end | ||
|
|
||
| # active_support/core_ext/date_time/conversions.rb | ||
| class Datetime |
There was a problem hiding this comment.
typo?
| class Datetime | |
| class DateTime |
There was a problem hiding this comment.
Oops, my bad! Thanks for noticing. I fixed it.
|
Note: refs: rails/rails#44354 |
- ActiveSupport::NumericWithFormat - https://api.rubyonrails.org/v7.0.8.6/classes/ActiveSupport/NumericWithFormat.html#method-i-to_fs - ActiveSupport::RangeWithFormat - https://api.rubyonrails.org/v7.0.8.6/classes/ActiveSupport/RangeWithFormat.html#method-i-to_fs - Array - https://api.rubyonrails.org/v7.0.8.6/classes/Array.html#method-i-to_fs - Date - https://api.rubyonrails.org/v7.0.8.6/classes/Date.html#method-i-to_fs - DateTime - https://api.rubyonrails.org/v7.0.8.6/classes/DateTime.html#method-i-to_fs - Time - https://api.rubyonrails.org/v7.0.8.6/classes/Time.html#method-i-to_fs
dak2
force-pushed
the
activesupport/to_fs
branch
from
cb5f911 to
5000fe9
Compare
|
/merge |
