Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create metric tags enriching profiler #54

Open
TimurKasatkin opened this issue Aug 13, 2021 · 0 comments
Open

create metric tags enriching profiler #54

TimurKasatkin opened this issue Aug 13, 2021 · 0 comments

Comments

@TimurKasatkin
Copy link
Member

Problem

Currently aggregating-profiler supports following decorators for enriching metrics:

Let's consider issue ru-fix/jfix-armeria#24 - if we want to add client_name label to metrics, currently we will need to add knowledge about such field to implementation of http metrics writer. That is, we will increase http metrics writer complexity for only putting additional tag to metrics it produces.

Suggestion

Add TagsEnrichingProfiler(additionalTags: Map<String, String>, profiler: Profiler) decorator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant