Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

07_widgets example shouldn't use submitButton #1355

Closed
wch opened this issue Sep 1, 2016 · 2 comments · Fixed by #1475 · May be fixed by rstudio/shiny-examples#54
Closed

07_widgets example shouldn't use submitButton #1355

wch opened this issue Sep 1, 2016 · 2 comments · Fixed by #1475 · May be fixed by rstudio/shiny-examples#54
Assignees
@bborgesr

Comments

@wch
Copy link
Collaborator

wch commented Sep 1, 2016 •
edited by bborgesr
Loading

No description provided.

@wch
Copy link
Collaborator Author

wch commented Nov 17, 2016

It would also be good to update the submitButton documentation to encourage use of actionButton instead of submitButton.

Also, the corresponding app in shiny-examples should be updated to match.

@bborgesr
Copy link
Contributor

Also, update the article http://shiny.rstudio.com/articles/action-buttons.html to include a paragraph of when it is appropriate to use a submit button (and include tiny example)

@wch wch self-assigned this Nov 17, 2016
@bborgesr bborgesr mentioned this issue Nov 17, 2016
Closed
@bborgesr bborgesr assigned bborgesr and unassigned wch Nov 18, 2016
@bborgesr bborgesr mentioned this issue Nov 21, 2016
Merged
@bborgesr bborgesr added review and removed targeted labels Nov 21, 2016
@bborgesr bborgesr mentioned this issue Nov 21, 2016
Open
@wch wch closed this as completed in #1475 Nov 28, 2016
@wch wch removed the review label Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bborgesr bborgesr

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wch @bborgesr