Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagAppend*(.cssSelector = "foo") et al should warn when it does nothing #344

Open
cpsievert opened this issue Oct 25, 2022 · 0 comments
Open

tagAppend*(.cssSelector = "foo") et al should warn when it does nothing #344

cpsievert opened this issue Oct 25, 2022 · 0 comments
Assignees
@schloerke

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented Oct 25, 2022 •
edited
Loading

Currently, when .cssSelector returns empty results, the tagAppend*() family does nothing to warn you about it (it probably should?)

tagAppendChild(span(), .cssSelector = ".foo", 1)
<span></span>

Same goes for any function that has a .cssSelector argument
@cpsievert cpsievert changed the title tagAppend*(.cssSelector = "foo") should warn when it does nothing tagAppend*(.cssSelector = "foo") et al should warn when it does nothing Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schloerke @cpsievert