Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gganimate to Imports #94

Open
aravindhebbali opened this issue Jul 31, 2024 · 0 comments
Open

Move gganimate to Imports #94

aravindhebbali opened this issue Jul 31, 2024 · 0 comments
Assignees
Labels

Comments

@aravindhebbali
Copy link
Member

Current Behavior

User installs the rfm package, gganimate is not installed as it is not included in Imports. When any of the below functions are called with the animate argument set to TRUE:

  • rfm_plot_segment_summary()
  • rfm_plot_segment_scatter()
  • rfm_plot_revenue_dist()
  • rfm_plot_median_recency()
  • rfm_plot_median_frequency()
  • rfm_plot_median_monetary()
  • rfm_plot_order_dist()

the package checks if gganimate is already installed. If yes, it generates the plot, else, it prompts the user to install gganimate.

New Behavior

Move gganimate to Imports. This ensures that the user need not be bothered to install gganimate if its not already installed.

@aravindhebbali aravindhebbali self-assigned this Jul 31, 2024
aravindhebbali added a commit that referenced this issue Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant