New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tons of complex constructors #1562

Open

fedejinich opened this issue Jun 15, 2021 · 0 comments

Labels

core ⚛️ good first issue tech debt & clean code

Contributor

fedejinich commented Jun 15, 2021 •

edited

Loading

There are tons of constructors with a lot of parameters, all over the rskj code. This makes it harder to review and also encourages potential bugs.

We can try to manage it by introducing a generic builder, or try to spot the most relevant ones and fix them.

fedejinich added core ⚛️ tech debt & clean code good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment