Move the ReaderWriterFactory
to the rosbag2_cpp
layer
#1703
Labels
enhancement
New feature or request
ReaderWriterFactory
to the rosbag2_cpp
layer
#1703
Description
Move the
ReaderWriterFactory
to therosbag2_cpp
layerCurrently the
ReaderWriterFactory
is part of therosbag2_transport
package and part of its namespace.However, the
ReaderWriterFactory
doesn't have any dependencies from therosbag2_transport
package.It will be more appropriate if the
ReaderWriterFactory
will be located at therosbag2_cpp
package.Related Issues
ReaderWriterFactory
to construct a bagfile reader ros2_documentation#4499Completion Criteria
ReaderWriterFactory
moved to therosbag2_cpp
layer and all dependencies in the rosbag2 updated.Implementation Notes / Suggestions
Since this is an API-breaking change, we can't just move
ReaderWriterFactory
from therosbag2_transport
namespace to therosbag2_cpp
. Instead, need to add a deprecation flag to therosbag2_transport::ReaderWriterFactory
and add a newrosbag2_cpp::ReaderWriterFactory
.Testing Notes / Suggestions
Move relevant tests if they exist from the
rosbag2_transport
layer to therosbag2_cpp
layer.The text was updated successfully, but these errors were encountered: