Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the ReaderWriterFactory to the rosbag2_cpp layer #1703

Open
1 task
MichaelOrlov opened this issue Jun 10, 2024 · 0 comments
Open
1 task

Move the ReaderWriterFactory to the rosbag2_cpp layer #1703

MichaelOrlov opened this issue Jun 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@MichaelOrlov
Copy link
Contributor

Description

Move the ReaderWriterFactory to the rosbag2_cpp layer

Currently the ReaderWriterFactory is part of the rosbag2_transport package and part of its namespace.
However, the ReaderWriterFactory doesn't have any dependencies from the rosbag2_transport package.
It will be more appropriate if the ReaderWriterFactory will be located at the rosbag2_cpp package.

Related Issues

Completion Criteria

  • The ReaderWriterFactory moved to the rosbag2_cpp layer and all dependencies in the rosbag2 updated.

Implementation Notes / Suggestions

Since this is an API-breaking change, we can't just move ReaderWriterFactory from the rosbag2_transport namespace to the rosbag2_cpp. Instead, need to add a deprecation flag to the rosbag2_transport::ReaderWriterFactory and add a new rosbag2_cpp::ReaderWriterFactory.

Testing Notes / Suggestions

Move relevant tests if they exist from the rosbag2_transport layer to the rosbag2_cpp layer.

@MichaelOrlov MichaelOrlov added the enhancement New feature or request label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant