Add list of distros branches to README #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #294 Signed-off-by: Shane Loretz <[email protected]>
sloretz
force-pushed
the
sloretz_examples_294_readme_branches
branch
from
f13aeac
to
3030201
Compare
| This repo targets different ROS distributions on different branches. | ||
| You must use the branch matching the ROS distro being used when building from source. | ||
|
|
||
| Ony [non-EOL ROS distributions](https://index.ros.org/doc/ros2/Releases/) are supported. |
There was a problem hiding this comment.
just a thought, but it might be a good idea to quickly elaborate/explain what "are supported" means here, especially since the table below lists both supported and unsupported distros.
also, Ony -> Only
There was a problem hiding this comment.
Actually, instead of a negative ("non-EOL"), I'd suggest the positive ("currently supported"). So maybe rewrite the sentence something like:
Suggested change
| Ony [non-EOL ROS distributions](https://index.ros.org/doc/ros2/Releases/) are supported. | |
| Changes are only accepted for [currently supported ROS distributions](https://index.ros.org/doc/ros2/Releases/). |
|
Now that there's a rolling branch, all ROS distro branches match the distro name. I don't think this reduces confusion anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294