Fix compilation of downstream bindings that include yarp.i #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
traversaro
temporarily deployed
to
code-analysis
GitHub Actions
Inactive
|
Hi @randaz81 Once merged, we would need the tag 3.10.1 to address robotology/icub-main#992. |
|
randaz81
approved these changes
Nov 14, 2024
randaz81
added
the
Component: Bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3146 there was a regression, as a new file
swig_python_windows_preable.iwas included in theyarp.iand it was generated by CMake in its binary directory. However, that file is not supposed to be included (and it is not even availble in the include path) when a downstream project (likeicub-main) includes the file in its own.iswig binding file.This PR fixes the issue by only including the file when
yarp.iis used to generate the yarp bindings, and not when theyarp.iis included in a downstream project, by checking if theSWIG_GENERATING_YARP_BINDINGSpreprocessor macro (that is only defined in the CMake build of YARP bindings) is defined.Fix robotology/icub-main#992 .