Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Diagnostic ResourceAlreadyImported Not Reported Since v0.94 #353

Open
martinezlc99 opened this issue Nov 15, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@martinezlc99
Copy link

Describe the bug
Since v0.94, aka this works with v0.93.1, robotcode stopped reporting ResourceAlreadyImported. I have tried a few of the diagnostics errors here

class Error:
VARIABLE_NOT_FOUND = "VariableNotFound"
ENVIRONMENT_VARIABLE_NOT_FOUND = "EnvironmentVariableNotFound"
KEYWORD_NOT_FOUND = "KeywordNotFound"
LIBRARY_CONTAINS_NO_KEYWORDS = "LibraryContainsNoKeywords"
POSSIBLE_CIRCULAR_IMPORT = "PossibleCircularImport"
RESOURCE_EMPTY = "ResourceEmpty"
IMPORT_CONTAINS_ERRORS = "ImportContainsErrors"
RECURSIVE_IMPORT = "RecursiveImport"
RESOURCE_ALREADY_IMPORTED = "ResourceAlreadyImported"
VARIABLES_ALREADY_IMPORTED = "VariablesAlreadyImported"
LIBRARY_ALREADY_IMPORTED = "LibraryAlreadyImported"
LIBRARY_OVERRIDES_BUILTIN = "LibraryOverridesBuiltIn"
DEPRECATED_KEYWORD = "DeprecatedKeyword"
KEYWORD_CONTAINS_ERRORS = "KeywordContainsErrors"
RESERVED_KEYWORD = "ReservedKeyword"
PRIVATE_KEYWORD = "PrivateKeyword"
INCORRECT_USE = "IncorrectUse"
KEYWORD_NAME_EMPTY = "KeywordNameEmpty"
CODE_UNREACHABLE = "CodeUnreachable"
TESTCASE_NAME_EMPTY = "TestCaseNameEmpty"
KEYWORD_CONTAINS_NORMAL_AND_EMBBEDED_ARGUMENTS = "KeywordContainsNormalAndEmbbededArguments"
DEPRECATED_HYPHEN_TAG = "DeprecatedHyphenTag"
DEPRECATED_RETURN_SETTING = "DeprecatedReturnSetting"
DEPRECATED_FORCE_TAG = "DeprecatedForceTag"
IMPORT_REQUIRES_VALUE = "ImportRequiresValue"
KEYWORD_ERROR = "KeywordError"
MULTIPLE_KEYWORDS = "MultipleKeywords"
CONFLICTING_LIBRARY_KEYWORDS = "ConflictingLibraryKeywords"
INVALID_HEADER = "InvalidHeader"
DEPRECATED_HEADER = "DeprecatedHeader"
OVERRIDDEN_BY_COMMANDLINE = "OverriddenByCommandLine"
VARIABLE_ALREADY_DEFINED = "VariableAlreadyDefined"
VARIABLE_OVERRIDDEN = "VariableOverridden"
MODEL_ERROR = "ModelError"
TOKEN_ERROR = "TokenError"

and they appeared to be ok, but I have not done an exhaustive test

Steps To Reproduce
Steps to reproduce the behavior:

  1. Import the same resource file twice in a row
  2. Observe no ResourceAlreadyImported
  3. Also, when a duplicate resource exists, the control/command + click to go to the definition does not work. For non duplicate resource files, this works.

I'll continue to try to debug, but this appears to be a regression

Desktop (please complete the following information):

  • VS Code Version - 1.95.3
  • RobotCode Version - v0.94 and up
  • OS: both Win 11 and macOS Sequoia 15.1
  • Python Version - 3.12.7
  • RobotFramework Version - 7.1.1
  • robocop - 5.4.0
  • robotidy - 4.14.0
@martinezlc99 martinezlc99 added the bug Something isn't working label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant