Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RojoResolver gets stuck on any form of recursion #24

Open
Dionysusnu opened this issue Jun 20, 2021 · 0 comments
Open

RojoResolver gets stuck on any form of recursion #24

Dionysusnu opened this issue Jun 20, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@Dionysusnu
Copy link
Contributor

Dionysusnu commented Jun 20, 2021

Version

roblox-ts: latest master

@rbxts/types: unrelated but 1.0.463

Description

RojoResolver gets stuck on anything that recurses, for example a node with "$path": ".", because it keeps walking that directory and rediscovering the node, then walking the directory and so on...
https://discord.com/channels/476080952636997633/494540040991539200/856293968529850398

Minimal Reproduction

{
	"name": "something",
	"tree": { "$path": "." }
}

Expected behavior:

Compiler detects that the node has already been walked, and either continues or emits an error

Current behavior:

Compiler loops forever or exceeds call stack limit

Playground link

Not applicable

@Dionysusnu Dionysusnu added the bug Something isn't working label Jun 20, 2021
@osyrisrblx osyrisrblx transferred this issue from roblox-ts/roblox-ts Feb 17, 2022
@Dionysusnu Dionysusnu changed the title RojoResolver gets stuck on node with "$path": "." RojoResolver gets stuck on any form of recursion Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant