-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Python 3.10 #13
Comments
@rjjanuary, I was able to get it to work locally with 3.10 by just dropping that param and you are correct that it is easy. Definitely be a breaking change with it then requiring 3.10. We just implemented the aiosfstream project and had to put it on 3.9. |
|
@robertmrk what would be the way forward here? I admit I don't know asyncio in that much detail, but I assume that the Or would you accept a PR that just checks the python version and omits the |
There hasn't been any activity from the maintainer for 4-5 years now. Perhaps @Andrei-Pozolotin could open his https://github.com/random-python/x_aiocometd repo for issue posting and we continue there? |
Usage of the "loop" variable within asyncio was deprecated in 3.8. Now in 3.10 it appears the use of the variable now errors.
Good news seems to be simply removing the use of loop allows the code to work "as is". I'm still trying to wrap my brain around the library, however at least wanted to drop a message that support for 3.10+ may be easy to implement.
The text was updated successfully, but these errors were encountered: