Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete translations #3187

Open
XVilka opened this issue May 16, 2023 · 6 comments
Open

Incomplete translations #3187

XVilka opened this issue May 16, 2023 · 6 comments
Labels
good first issue Easy issues for new comers. Help Wanted High Priority This issue should be handled as soon as possible since it describes a major problem in Cutter Qt Issues and pull-requests regarding or caused-by the underlying Qt toolkit. Translations Issues regarding Cutter's interface translations (CrowdIn) and Documentation translations UI
Milestone
2.4

Comments

@XVilka
Copy link
Member

XVilka commented May 16, 2023 •
edited
Loading

Some strings are still untranslated while Crowdin says it's 100% complete for the target language (Japanese)
It happens on all languages. Note "Dashboard", "Sections", "Strings":

image

Likely it's because they are defined in the UI files:

ℤ rg "\"Dashboard\""
src/widgets/Dashboard.ui
4: <widget class="QDockWidget" name="Dashboard">

See https://wiki.qt.io/QtInternationalization
@XVilka XVilka added this to the 2.3 milestone May 16, 2023
@XVilka XVilka added good first issue Easy issues for new comers. UI Translations Issues regarding Cutter's interface translations (CrowdIn) and Documentation translations labels May 17, 2023
@XVilka XVilka pinned this issue May 17, 2023
@XVilka XVilka added the High Priority This issue should be handled as soon as possible since it describes a major problem in Cutter label Jun 12, 2023
@sambhujimmi
Copy link

Hi, I'm a first timer.
Can I take this issue?

@XVilka
Copy link
Member Author

XVilka commented Jun 16, 2023

@sambhujimmi sure, go for it

@XVilka XVilka added the Qt Issues and pull-requests regarding or caused-by the underlying Qt toolkit. label Jun 16, 2023
@XVilka
Copy link
Member Author

XVilka commented Jun 21, 2023

One more issue - not all languages are shown in the menu - e.g., after the latest translations submodule update, the Ukrainian language is still missing

image

@XVilka XVilka mentioned this issue Jul 5, 2023
Merged
3 tasks
@XVilka
Copy link
Member Author

XVilka commented Jul 7, 2023 •
edited
Loading

As for missing languages, it's because they are directly listed in the CMake file (cmake/Translations.cmake); we should use globs, see #3124

@XVilka XVilka mentioned this issue Aug 2, 2023
Merged
3 tasks
@XVilka XVilka modified the milestones: 2.3, 2.4 Aug 4, 2023
@XVilka XVilka mentioned this issue Sep 22, 2023
Open
@XVilka XVilka mentioned this issue Jan 29, 2024
Closed
@GermanAizek
Copy link
Contributor

@XVilka,
here are some fixes translated strings
0001-Additionals-translate-strings.patch

@XVilka XVilka mentioned this issue Jan 29, 2024
Draft
3 tasks
@XVilka
Copy link
Member Author

XVilka commented Jan 29, 2024

@GermanAizek thanks, I sent a PR: #3289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easy issues for new comers. Help Wanted High Priority This issue should be handled as soon as possible since it describes a major problem in Cutter Qt Issues and pull-requests regarding or caused-by the underlying Qt toolkit. Translations Issues regarding Cutter's interface translations (CrowdIn) and Documentation translations UI
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
3 participants
@XVilka @GermanAizek @sambhujimmi