Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads empty files #9

Open
Ploppz opened this issue Apr 1, 2018 · 7 comments
Open

Downloads empty files #9

Ploppz opened this issue Apr 1, 2018 · 7 comments

Comments

@Ploppz
Copy link

Ploppz commented Apr 1, 2018

In this example in the docs, download() downloads only empty files. I got the same result personally when I tried to download an audiostream.

@ritiek ritiek added the bug label Apr 2, 2018
@ritiek
Copy link
Owner

ritiek commented Apr 2, 2018

Thanks for the report! I can confirm this. I haven't worked on this library lately but I'll see what I can do.

@ritiek
Copy link
Owner

ritiek commented Apr 2, 2018

Actually, it looks like YouTube messed up with a few videos. Some other ones like https://www.youtube.com/watch?v=UuEHqk8M6Fc download okay.

@Ploppz
Copy link
Author

Ploppz commented Apr 2, 2018 via email

@ritiek
Copy link
Owner

ritiek commented Apr 2, 2018

It looks like pafy works with that video only when youtube-dl backend is enabled. It won't work for me if backend is set to internal.

$ export PAFY_BACKEND="internal"

To support these videos in rafy, we're going to have to set up youtube-dl backend as well just like pafy.

@Ploppz
Copy link
Author

Ploppz commented Apr 2, 2018

Is there no other way? (i.e. what is youtube-dl doing that rafy is not doing) How much work would it take to use this backend? Requires FFI to Python I guess.
Will you do it?

@ritiek
Copy link
Owner

ritiek commented Apr 3, 2018

Is there no other way? (i.e. what is youtube-dl doing that rafy is not doing)

YouTube keeps undergoing changes I can't possibly keep track of and make appropriate fixes ASAP. youtube-dl manages that pretty good and personally I think we should try our best to avoid duplicate effort.

How much work would it take to use this backend? Requires FFI to Python I guess.

I am not sure at the moment. I'll have to take a deeper look as I haven't worked with FFI much before.

Will you do it?

I am willing to accept PRs but I'll also integrate myself when I set my mood on it. :)

@Ploppz
Copy link
Author

Ploppz commented Apr 3, 2018

Ok, I looked into it and seems like we can do it with cpython. I will try to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants