Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make initial generated link clickable and opens a new tab #2

Open
1 of 3 tasks
priambudiLB opened this issue Oct 13, 2021 · 3 comments · May be fixed by #3
Open
1 of 3 tasks

Make initial generated link clickable and opens a new tab #2

priambudiLB opened this issue Oct 13, 2021 · 3 comments · May be fixed by #3

Comments

@priambudiLB
Copy link

priambudiLB commented Oct 13, 2021

This issue is a:

  • bug report
  • feature request
  • styling change request

Current behavior:

After generate a new link, a box with the generated URL & copy button will appear. The link is unclickable.
Screen Shot 2021-10-13 at 23 26 30

Requested behavior:

The generated link in the box being clickable.

Why this behavior is better:

I think most of the user will test the link by clicking the copy button, open a new tab, and paste then press enter. Making the link clickable to open the generated link in a new tab will save the user's time rather than: clicking the copy button -> open a new tab -> paste the link. We should keep the copy button, just add a new functionality to open the generated link in a new tab.

@priambudiLB
Copy link
Author

I would like to work on this issue if possible.

@priambudiLB priambudiLB linked a pull request Oct 13, 2021 that will close this issue
@priambudiLB
Copy link
Author

I just created a PR, please check my implementation and review when possible.

Is this project's Unit Test hasn't been setup yet? I have no experience in setting up Unit Tests using Next.JS. Perhaps the maintainers could help to create a sample test for others to follow.

@jonathanfilbert
Copy link
Member

Is this project's Unit Test hasn't been setup yet? I have no experience in setting up Unit Tests using Next.JS. Perhaps the maintainers could help to create a sample test for others to follow.

I think Jest would be useful here for unit testing. Please make a separate issue for the unit testing so we can get others working on it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants