Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with prior jsoup adding extra blank lines does not remove those lines with latest 2.18.0 #604

Open
hazendaz opened this issue Mar 2, 2022 · 0 comments
Assignees

Comments

@hazendaz
Copy link
Member

hazendaz commented Mar 2, 2022

Prior to formatter-maven-plugin 2.18.0, jsoup had a bug that caused extra blank lines to be added each time file was formatted when it had inline javascript. This was fixed in 2.18.0. However, the extra blank lines are not then removed. We need to add one more enhancement similar to what is being done in the xml formatter that will remove duplicate blank lines (for example 3 blank lines should just be 1). Given that is via jsoup, the fix will likely need made there similar to what is being done with the xml formatter which I believe we have planned given some further code updates for 2.19.0 either later this month or into April 2022.

In order to see this, we will need to adjust our current html file test that is really hosed to have a lot of empty blank spaces. So it should then format + remove blank lines to be considered appropriate on our two pass formatting model.

I plan to look to this in coming weekend now that it has been confirmed as still partial issue in the wild.

@hazendaz hazendaz added this to the 2.19.0 milestone Mar 2, 2022
@hazendaz hazendaz self-assigned this Mar 2, 2022
@ctubbsii ctubbsii modified the milestones: 2.19.0, 2.20.0 Jun 1, 2022
@hazendaz hazendaz removed this from the 2.20.0 milestone Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants