Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for BYO Deserializer #2

Open
tychoish opened this issue Feb 27, 2024 · 4 comments
Open

add support for BYO Deserializer #2

tychoish opened this issue Feb 27, 2024 · 4 comments

Comments

@tychoish
Copy link

I would kind of enjoy being able to use simd_json with this library, which I think could be achieved by permitting a BYO/dependency injectable Deserializer. I don't think this library would need to pick up the dependency, (but it could be feature flagged out or test-only) but it would offer a fair amount of flexibility.

Would you be interested in accepting a patch like this? I'm willing to do some (or more) of this work, if you like.

@d0nutptr
Copy link
Contributor

I 100% would accept a patch to do this! Fantastic idea!

@tychoish
Copy link
Author

tychoish commented Mar 4, 2024

I did a bit of poking to try and do this, and it definitely is not as easy as I initially expected, it would be, but I'm slightly newer to rust and my estimation game is of. My idea of "just put a deserializer object in a field on the struct" doesn't quite work as I wanted to. If there's a pattern or something that you'd like to see I'm definitely ears. I'll get back to this (probably) at some point regardless, but am definitely open to ideas.

@d0nutptr
Copy link
Contributor

d0nutptr commented Mar 5, 2024

hey @tychoish !

I just wanted to let you know I see all of the PRs and comments coming into my email but I've just been a bit busy the last couple of days. Later this week I swear I'll get back to you 😅 . I hope that's okay! Thank you so much for taking an interest in this crate. I'll make sure to get it doing what you need, soon ™️ :)

@tychoish
Copy link
Author

tychoish commented Mar 5, 2024

Thanks!

This is more of a "wouldn't it be nice if..." kind of thing, and the other stuff (captured in the PR) is actually the stuff I need/want. I totally understand busy. Look forward to hearing from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants