Use array for positions #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR currently only changes |
|
Any ideas as to why this build is failing? According to Travis: Why would the render command create this error? I've been tracing through calls but haven't found anything that sticks out. |
|
Happy to take a deeper dive in the coming days, if necessary. Also looping in @ArmanMazdaee and @erbesharat for additional help, if needed. |
|
Just checking in. Did the render_test.go file help in figuring out the failing tests? @ArmanMazdaee Care to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes
positionto be an array of strings representing different job positions.fixes #86