Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rendering (texture/buffer/pipeline etc.) DebugLabels in release builds #8640

Open
Wumpf opened this issue Jan 10, 2025 · 0 comments
Open
Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less 🔺 re_renderer affects re_renderer itself

Comments

@Wumpf
Copy link
Member

Wumpf commented Jan 10, 2025

Right now we remove all DebugLabel from release builds. From experience that's overzealous - they don't cost us a lot, we have nothing to hide and debugging release applications just gets harder

We should still keep around the abstraction in case we change our minds and/or want to disable them on web builds to save a bit on size.

One nasty thing to keep in mind is that debug labels currently affect our gpu resource re-usage: We re-use a texture/buffer if it has the exact same descriptor including the DebugLabel. I suggest we ignore the debug label for that purpose on release builds but keep it in on debug builds with a small annotation indicating that it might have been renamed (it's not possible to change debug labels after the fact unfortunately).

@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself 😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍💻 dev experience developer experience (excluding CI) 🏎️ Quick Issue Can be fixed in a few hours or less 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

No branches or pull requests

1 participant