Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Validation in Load Balancer Collector Caps Address Length at 63 Characters Instead of 255 #1620

Open
diamonwiggins opened this issue Sep 23, 2024 · 1 comment
Labels
bug::normal type::bug Something isn't working

Comments

@diamonwiggins
Copy link
Member

Bug Description

The function used from the Kubernetes validation library to validate DNS addresses during the preflight check for load balancer addresses imposes an unintended 63-character limit. This limit stems from the validation criteria used for pod/service DNS names, but in the case of load balancer addresses, the specified address can be up to 255 characters. The validation should allow for the full 255-character length rather than being capped at 63 characters.

Expected Behavior

Compliant DNS addresses are respected in the tcpLoadBalancer collector

Steps To Reproduce

  1. Run a preflight check for a load balancer address using an address longer than 63 characters.
  2. Observe that the validation fails despite the address being under the 255-character limit.

Additional Context

Include the following information.

  • Troubleshoot version. If you built from source, note that including the version of Go you used to build with.

  • Operating system

  • Operating system version

  • Other details that might be helpful in diagnosing the problem

  • Troubleshoot v0.103.0

@diamonwiggins diamonwiggins added type::bug Something isn't working bug::normal labels Sep 23, 2024
@chris-sanders
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants