Spec errors seem to be eaten when specs come from a secret

[crdant]

Bug Description

While working on some specs for a new app we put them into the Helm chart and did some templating to share some of the collectors and analyzers between preflights and support bundles. The templates for the Registry Image collector depended on a tag being set in a Helm value and we did an install where that value wasn't set. In this scenario, the spec became invalid because the registry image was listed as registry/repository/path/to/image: with no tag at the end.

Instead of reporting the error, both the command-line tools and the invocation within the KOTS Admin Console treated the situation as there being no specs available.

Expected Behavior

The expected behavior is that the tooling will identify that a spec is available in the Helm template/in-cluster secret and report that the spec has an error.

Steps To Reproduce

Induce an error into a spec that is included in a Helm chart secret and attempt to invoked the preflight/support bundle from either the CLI or the KOTS admin console. The command-line tools will report there is no spec available, and the Admin Console will either skip preflights or generate a default support bundle.

Additional Context

See slack thread on Replicated Slack if you have access.

[xavpaice]

https://app.shortcut.com/replicated/story/110559/extend-troubleshoot-linter-to-include-secrets-in-helm-charts-in-a-release