Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu link text too dark when active and in dark mode #26

Open
ReinhardtBotha opened this issue Sep 10, 2022 · 4 comments
Open

Menu link text too dark when active and in dark mode #26

ReinhardtBotha opened this issue Sep 10, 2022 · 4 comments

Comments

@ReinhardtBotha
Copy link

The menu link text color is dark when active and the theme is in dark mode, which makes it illegible. Here are screenshots with the Tags link active.

Dark Mode:
image

Light Mode:
image

@BedirT
Copy link

BedirT commented Sep 13, 2022

I don't think that is about the theme. I believe you are using some additional CSS to modify the navigation bar.

@ReinhardtBotha
Copy link
Author

I also thought so, but it does the same on the demo site (https://reorx.github.io/hugo-PaperModX/). Maybe it's due to the latest CSS updates to the theme?

@BedirT
Copy link

BedirT commented Sep 22, 2022

Just found out what causes this. After updating to the most recent version I got the same error. It is due to these lines here:

/* for type pages theming */
--signature: var(--primary);
--signature-bg: var(--secondary);

He is using the signature as the colour variable which does not change based on the theme dark/light version. Because the dark version doesn't have signature defined, I'll submit a tiny pr I think for this. Minor mistake :)

@reorx

@itsamemarkus
Copy link

Thanks for the pull request! Noticed that too.

Just wondering if there is a bigger problem with light/dark theme because accent colors defined in assets/css/extended/custom.css only work for the light theme, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants