Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculate semanticCommitType priority #32069

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

breadadams
Copy link

Changes

  • Introduce logic to lib/workers/repository/updates/generate.ts for getting the common semanticCommitType based on priority.
  • Add unit tests.

Context

Closes #31979

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@breadadams
Copy link
Author

I've tested this is working by running it on this repo: https://github.com/breadadams/renovate-semantic-commit-type-priority/pulls

If you compare against the original repro repo, you'll see that the new one opens both PRs with the fix prefix (as expected).

image

@breadadams
Copy link
Author

Hi @rarkins, is there anything missing here? Sorry for the ping, just wondering if maybe this slipped by. Thanks

@rarkins
Copy link
Collaborator

rarkins commented Oct 30, 2024

I have this saved for follow-up, just unfortunately have had little time recently

lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved
lib/workers/repository/updates/generate.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semanticCommitType awareness to generateBranchConfig()
2 participants