Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async getQuery #297

Open
taion opened this issue Jul 1, 2019 · 4 comments
Open

Support async getQuery #297

taion opened this issue Jul 1, 2019 · 4 comments

Comments

@taion
Copy link
Member

taion commented Jul 1, 2019

Follow-up feature request from #294

@jquense
Copy link
Contributor

jquense commented Jul 1, 2019

isn't this better solved by persistent queries?

@taion
Copy link
Member Author

taion commented Jul 1, 2019

Probably.

@dminkovsky
Copy link
Contributor

I don't know, I liked your reasoning. I think I was mislead by the apparent tidiness of keeping the query with the module. If this capability existed, it would have lead me down the wrong path?

@taion
Copy link
Member Author

taion commented Jul 1, 2019

Yeah, we probably don't want to do anything here. It probably makes sense to use persistent queries and only send up the query hash, in cases where we want to omit the weight of queries from the main bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants