Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Create a Makefile #4

Open
rudolfbyker opened this issue Jun 2, 2016 · 3 comments
Open

Create a Makefile #4

rudolfbyker opened this issue Jun 2, 2016 · 3 comments

Comments

@rudolfbyker
Copy link
Member

The rsc2014 and rsc14_cl subthemes have scss files which have to be compiled to css. A specific version of compass is needed to make it work with the Zen theme. See https://www.drupal.org/node/2353067#comment-9567305 for more info. I have to look that up every time I update the theme, which is a hassle.

We need a Makefile (or two?) which compiles the scss with either
compass _0.12.6_ watch
or
compass _0.12.6_ compile

@rudolfbyker
Copy link
Member Author

Commits 54a657d and ff6ae47 attempt to address this problem by including the .css files in the repo. I don't think that's an optimal solution. @krokkie please comment.

@krokkie
Copy link

krokkie commented Jul 30, 2016

This is somewhat of a pragmatic hack.
But I guess there is no harm in including the CSS files.

We are using "drush make" to pull this theme/repo in some of the sites. The "drush make" command does not automatically compile the compass stuff, so we end up using a theme without any CSS files. If there is a way to make the "drush make" command do this automatically, it would be better.
Sounds like https://www.drupal.org/project/drush_compass might provide some of this functionality - not sure.

@rudolfbyker
Copy link
Member Author

Includiing css files causes lots of merge conflicts, since one line of scss can change many lines of css in many different places. Workaround: Always use merge strategy ours for .css files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants