[ENG-4080]Downgrade syntax highlighter to fix wrapLongLines issue
#4368
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahAhianyo
changed the title
wrapLongLines issuewrapLongLines issue
|
How does ReactSyntaxHighligter |
That's what's not obvious to me. We don't, by default, set any css props, which should work the way it is. The referenced PR only swaps the order of args, so maybe a chain of reaction somewhere? I haven't dug into the reactsyntaxhighlighter codebase to to see what other parts may have been affected. Either way, Im not sure if this will require a fix from us than them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactSyntaxHighligter
v15.16.1breaks the functionality of thewrap_long_lineprop. Downgrading to15.16.0works.Related upstream PR: react-syntax-highlighter/react-syntax-highlighter#487