Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the dgrijalva/jwt-go library #779

Closed
mihaitodor opened this issue May 27, 2021 · 4 comments
Closed

Update the dgrijalva/jwt-go library #779

mihaitodor opened this issue May 27, 2021 · 4 comments
Labels
task A general task for the project or repo that doesn't fit any other label waiting for upstream Blocked on changes needed in an upstream dependency

Comments

@mihaitodor
Copy link
Collaborator

PR #772 introduced a slightly outdated version of dgrijalva/jwt-go which might require some critical patches (for example this one). Unfortunately, the original author doesn't have time to maintain it so there is a conversation happening here to figure out a permanent home for this popular library. I have subscribed to this conversation and will submit a PR with the updated lib once the dust settles.
@mihaitodor mihaitodor mentioned this issue May 27, 2021
Merged
@Jeffail
Copy link
Collaborator

Jeffail commented May 28, 2021

Awesome, thanks @mihaitodor!

@Jeffail Jeffail added task A general task for the project or repo that doesn't fit any other label waiting for upstream Blocked on changes needed in an upstream dependency labels May 28, 2021
@oxisto
Copy link
Contributor

oxisto commented May 28, 2021

Just saying, hi! We are setting up a community effort clone of the aforementioned library at http://github.com/golang-jwt/jwt . We are still in the process of setting everything up, but we made great progress. golang-jwt/jwt#12 will fix the mentioned issue.

@mihaitodor
Copy link
Collaborator Author

Thank you very much @oxisto! I'll keep an eye on it.

@oxisto
Copy link
Contributor

oxisto commented Jun 9, 2021

We just released v3.2.1 with a fix. https://github.com/golang-jwt/jwt/releases/tag/v3.2.1

@Jeffail Jeffail closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task A general task for the project or repo that doesn't fit any other label waiting for upstream Blocked on changes needed in an upstream dependency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mihaitodor @Jeffail @oxisto