Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the typedef of lock.extend() to accept floats #3420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nbertram
Copy link

@nbertram nbertram commented Oct 31, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Switched the typedef of lock.extend() additional_time to use redis.typing.Number instead of int, to be consistent with the docstring and behavior.

@nbertram nbertram force-pushed the lock-extend-typedef-fix branch from 2ac6b51 to c1909f8 Compare November 1, 2024 00:57
@nbertram nbertram marked this pull request as ready for review November 1, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant