-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize PayPal and ApplePay with local braintree library #873
Comments
Recurly.JS will check if the module that is being requested ( Is the ask to provide the instance of the |
No, I want to speed-up recurly initialization by providing already bundled braintree package. So there no need to load this lib from 3rd party. (I use official braintree-web npm package) |
Per my comment above, we will not load the 3rd party library should the module be loaded already . Could you provide me with the BT library version you are using? I want to confirm that it does not match what RJS expects because that might be the reason why it is triggering the external load. If it doesn't match we might be able to loosen that version constraint since there isn't much in the way of breaking changes in the library in v3. |
I ensure that the same version of Braintree used by Recurly is bundled in my project: To handle this, I clear all Braintree references from the global window and allow Recurly to load all the dependencies itself. It would be more elegant to pass my Braintree version directly in the Recurly configuration. |
In my project we already have self-hosted braintree-web cleint from npm. It will be great to add option to initialize PayPal and ApplePay with my braintree library instanse, to skip 3rd party scripts loading in initialization.
The text was updated successfully, but these errors were encountered: